-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
add solution 146 with java #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
哈喽,有几个小地方
文件请规范命名
- Java 里 文件名与类名保持一致,首字母大写
e.g.
Solution.java
- README 文件命名请按照 GitHub 规范,README 全大写
e.g.
README.md
代码请规范书写
适当的空格是必要的
e.g.(不止这一处)
// 不规范的写法 Node newNode=new Node(key,value); //接下来要考虑容量 if(map.size()<capacity){ setHead(newNode); map.put(key,newNode); }
// 规范的写法 Node newNode = new Node(key, value); // 接下来要考虑容量 if (map.size() < capacity) { setHead(newNode); map.put(key, newNode); }
不妨修改一下😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add solution 146 with java