-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Add 147 Solution (java) #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Please enter a commit message to explain why this merge is necessary,
update to keep new
update 2019年1月10日
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mrzhudky 谢谢提交,这里有几个小问题想跟你说一下哈。
- 不要提交附加多余文件
.editorconfig - 一些代码的缩进格式不对
if/else,while书写不规范- 不要添加这一个 solution 而产生了 15 个 commits
我觉得你可以重新把最新的仓库 fork 到你的帐户下,clone 到本地,做出修改后 push 到你的帐户,然后再提个 PR。
虽然我指出了这些小地方,但我相信改起来是特别快的,加油噢,等你新的 PR。我先把这个 PR 关了。之后提交规范的话,我会把你加入到本项目的维护者中,跟其它小伙伴一起维护仓库哈~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里及以下的代码缩进不对噢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不要添加多余文件噢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
所有的 if/else 的书写都不规范噢,希望可以改一下。
- if 后面需要加一个空格,然后才开始左括号,比如
if (condition) { // statement here }
else 跟在上个 if 的 } 后面,用一个空格隔开。如
if (condition) { // statement here } else { // statement here }
- while 与 if 的写法一样
Add 147 solution.java and README.md