-
Couldn't load subscription status.
- Fork 32
[CSS] Improve Word Wrap in Parameter tables #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Found nth-child strategy here: https://css-tricks.com/how-nth-child-works/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice detail 👍 Can you unnest the td selector and use :last-child to improve browser support? Nesting and :nth-last-child are part of the 2023 baseline so most users should have a supported browser, but the suggested alternatives have broader support and should have the same result.
@zlovatt suggested using the td code selector which solves the wrapping problem in a much more targeted way. Thank you, Zack!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, apart from the nesting within :root. The selectors should be top-level.
For what it's worth:
- This change has been moved into global.css in the docsforadobe.dev homepage repo
- This repo (and all other child repos) will now look to the above global.css file(s) for org-wide css changes; these global changes should be done there.
More info in the docsforadobe.dev repo readme
Uh oh!
There was an error while loading. Please reload this page.
This is a CSS-only change to how wrapping is handled in table cells containing code. Prior to this change, many method parameter tables were wrapping poorly, with single characters broken out to their own lines for text formatted as code. Setting a
nowrapoverride using thetd codeselector prevents the code-formatted function parameters from being broken into separate lines.Testing:
Re-reviewed tables to ensure the wrapping remained consistent and correct.