-
Couldn't load subscription status.
- Fork 340
Add skip_common_chunks functionality #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
script tag issue #289. Uses context to store a list of all loaded tags by default and skips them if the option is set for that invocation of render_bundle
Modified jinja2ext to handle context; Added tests for takes_context and skip_common_chunks
bumperino
Yes it does. It is the same functionality but extended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushed a commit with some legibility improvements, and a point for @fjsj to check, otherwise LGTM.
bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot.
awesome \o/
now please make a release ASAP so we can use the actual updated version :)
We will make the release early next week, on Monday.
Release made: 1.4.0
As discussed in #296, I've added tests to work with Jinja and cleaned up the test suite to remove python3.5 and update to
Jinja2>3since python3.5 has reached EOL.Django<2.2is also non-LTS.