Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update tests to webpack 4 + babel 7 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@prayerslayer
Copy link

@prayerslayer prayerslayer commented Sep 28, 2018
edited
Loading

Hi!

I want to see splitChunks support here soon, so I figured I'll update tests to webpack 4 :)

Changes are mostly mechanical:

Updated packages

  • New versions for babel, webpack, react etc.
  • Replaced extract-text-css-plugin with mini-css-extract-plugin because that works in our project and there was a time where the former didn't work with webpack 4. I didn't check if that's still the case.
  • Removed webpack-split-by-path package, test + examples, because it's quite old (2 years) and webpack has splitting built-in now.

Updated webpack configs

Since I updated from webpack 1 to 4 the format of a webpack config changed a bit.

Updated test cases

They're not different, functionally speaking. styles.css became main.css because it's named as the bundle. The output order of the js and css chunk changed, but imo that shouldn't have been tested in the first place :) Other than that it's the same.

jpic reacted with thumbs up emoji
Copy link
Author

not sure what's wrong with travis here :/

Copy link
Member

fjsj commented May 6, 2021

Thanks for your contribution! We're reorganizing the project now.

@rvlb those commits are also at #261

Do you rather fix and merge this one first or focus on fixing 261?

@fjsj fjsj requested a review from rvlb May 6, 2021 13:17
Copy link
Member

fjsj commented Jul 15, 2021

I believe those behaviors are already tested on current master. If they are not, please let us know.

@fjsj fjsj closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvlb rvlb Awaiting requested review from rvlb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /