Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Appending extensions in the url files #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaopslins merged 10 commits into django-webpack:master from joshjo:master
Aug 23, 2021
Merged

Conversation

@joshjo
Copy link
Contributor

@joshjo joshjo commented Nov 9, 2017

In order to allow to import gzip files, this pull request adds a configuration section to load the gzip files.

SalahAdDin and wmai reacted with thumbs up emoji
Copy link
Collaborator

owais commented Nov 24, 2017
edited
Loading

Thanks but I think it would be better to add support to the template tags so they add a suffix to the files like

 {% render_bundle 'main' 'css' suffix='.gz' %}

Copy link
Collaborator

owais commented Nov 24, 2017

Copy link
Contributor Author

joshjo commented Dec 13, 2017

@owais updated pull request, the suffix now is added in the template tag.

tags.append((
'<link type="text/css" href="{0}" rel="stylesheet" {1}/>'
).format(chunk['url'], attrs))
).format(''.join([chunk['url'], suffix]), attrs))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not href="{0}{1}" {2}".format(url, suffix, attrs)?

KyeRussell reacted with thumbs up emoji
Copy link

jonalxh commented Mar 13, 2020

Please consider to merge it or make an .gzip implementation.

Copy link
Collaborator

owais commented Mar 13, 2020

Can someone confirm if this is still a viable solution and still works with the latest master before we merge it?

@fjsj fjsj requested a review from rvlb May 6, 2021 13:09
Copy link
Member

fjsj commented May 6, 2021

@rvlb could you please check this one?

@joaopslins joaopslins merged commit fffb889 into django-webpack:master Aug 23, 2021
Copy link
Contributor

FYI this was just included in the 1.3.0 version

owais and joshjo reacted with thumbs up emoji andruten and joshjo reacted with hooray emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owais owais owais approved these changes

@rvlb rvlb Awaiting requested review from rvlb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /