fix: Fix typo in permission name #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

fsbraun merged 1 commit into django-cms:master from stefan6419846:issue474

Jul 22, 2025

Merged

fix: Fix typo in permission name #476

fsbraun merged 1 commit into django-cms:master from stefan6419846:issue474

Jul 22, 2025

Conversation

@stefan6419846

Copy link

Contributor

@stefan6419846 stefan6419846 commented Jul 22, 2025 •

edited by sourcery-ai bot

Loading

Closes #474.

Description

Fixes a typo in the verbose name of a permission.

Related resources

Typo in verbose name of permission delete_versionlock #474

Checklist

I have opened this pull request against master
I have added or modified the tests when changing logic
I have followed the conventional commits guidelines to add meaningful information into the changelog
I have read the contribution guidelines and I have joined #workgroup-pr-review on
Slack to find a "pr review buddy" who is going to review my pull request.

Summary by Sourcery

Fix the typo in the verbose name of the delete_versionlock permission and add a database migration to apply the correction

Bug Fixes:

Correct typo in the verbose name of the delete_versionlock permission

Enhancements:

Add migration to update the corrected permission name in the database

@stefan6419846


 fix: Fix typo in permission name

e0a2158

Closes #474.

@sourcery-ai

Copy link

Contributor

sourcery-ai bot commented Jul 22, 2025 •

edited

Loading

Reviewer's Guide

This PR corrects a typo in the verbose name of the 'delete_versionlock' permission by updating the model definition and adding a migration to persist the change.

Class diagram for the updated Version model permission options

classDiagram
 class Version {
 <<model>>
 }
 Version : Meta
 class Meta {
 unique_together = ("content_type", "object_id")
 permissions = (("delete_versionlock", "Can unlock version"),)
 }
 Version --> Meta

File-Level Changes

Change	Details	Files
Corrected typo in permission verbose name	Updated verbose name from 'Can unlock verision' to 'Can unlock version'	`djangocms_versioning/models.py`
Added migration to apply permission label correction	Created 0018_fix_typo migration Used AlterModelOptions to update the 'delete_versionlock' permission text	`djangocms_versioning/migrations/0018_fix_typo.py`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#474	Correct the typo ('verision' to 'version') in the verbose name of the 'delete_versionlock' permission in djangocms_versioning/models.py.	✅
#474	Add a migration to update the permission verbose name in the database schema.	✅

Possibly linked issues

Typo in verbose name of permission delete_versionlock #474 : The PR fixes the 'verision' typo to 'version' in the permission name, directly addressing the issue.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

@stefan6419846 stefan6419846 changed the title ~~(削除) Fix typo in permission name (削除ここまで)~~ (追記) fix: Fix typo in permission name (追記ここまで)

Jul 22, 2025

sourcery-ai[bot]

sourcery-ai bot reviewed

Jul 22, 2025

View reviewed changes

Copy link

Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stefan6419846 - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

@stefan6419846

Copy link

Contributor Author

stefan6419846 commented Jul 22, 2025

The second part of the last todo item on the checklist has been omitted as the link to Slack returns a 404 and I do not see any benefit of registering there for such a simple change.

@stefan6419846 stefan6419846 had a problem deploying to test

July 22, 2025 16:36

— with GitHub Actions Failure

fsbraun

fsbraun approved these changes

Jul 22, 2025

View reviewed changes

Copy link

Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stefan6419846 !

@fsbraun fsbraun merged commit ce9c654 into django-cms:master

Jul 22, 2025

40 of 41 checks passed

@codecov

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (a132204) to head (e0a2158).
Report is 8 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 90.55% 93.66% +3.10% 
==========================================
 Files 72 76 +4 
 Lines 2732 2699 -33 
 Branches 322 0 -322 
==========================================
+ Hits 2474 2528 +54 
+ Misses 182 171 -11 
+ Partials 76 0 -76

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Labels

None yet

2 participants

@stefan6419846 @fsbraun

fix: Fix typo in permission name #476

fix: Fix typo in permission name #476

Uh oh!

Conversation

@stefan6419846 stefan6419846 commented Jul 22, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related resources

Checklist

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for the updated Version model permission options

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

stefan6419846 commented Jul 22, 2025

Uh oh!

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jul 22, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

@stefan6419846 stefan6419846 commented Jul 22, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jul 22, 2025 •

edited

Loading