-
Couldn't load subscription status.
- Fork 33
#336 bugfix from link_menu_item to modal_menu_item: discard changes link #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
svandeneertwegh
wants to merge
2
commits into
django-cms:master
from
svandeneertwegh:fix/link_to_modal-cancel-item
Open
#336 bugfix from link_menu_item to modal_menu_item: discard changes link #360
svandeneertwegh
wants to merge
2
commits into
django-cms:master
from
svandeneertwegh:fix/link_to_modal-cancel-item
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #360 +/- ## ======================================= Coverage 90.86% 90.86% ======================================= Files 72 72 Lines 2530 2530 Branches 356 356 ======================================= Hits 2299 2299 Misses 170 170 Partials 61 61
☔ View full report in Codecov by Sentry. |
@svandeneertwegh I have two observations:
- Upon confirming to discard changes, the modal does not close. Instead, the version list of the object is shown in the modal. I think the modal would need to close, and the page should probably redirect to the preview of the published version.
- It seems to me that the draft version actually is not discarded. I am not sure why. But it appears to stay in the version list shown in the modal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
The 'discard changes' link in the versioning menu item (toolbar) is with this PR changed from add_link_item to add_modal_item.
masterSlack to find a "pr review buddy" who is going to review my pull request.