-
Notifications
You must be signed in to change notification settings - Fork 179
NEW: Added component question type #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
phre1
merged 2 commits into
ditdot-dev:experimental/custom-question-type
from
venarius:feature/component-question-type
Sep 16, 2020
Merged
NEW: Added component question type #109
phre1
merged 2 commits into
ditdot-dev:experimental/custom-question-type
from
venarius:feature/component-question-type
Sep 16, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a really interesting suggestion - although we feel this should be tested and refined a bit more. If we decide to support this, we'd need to create and document some sort of plugin API that custom components would need to follow to make them fully integrated with the rest of Flow Form. We'll pull this request into an experimental branch so we can further test it out and possibly improve it.
@phre1
phre1
changed the base branch from
master
to
experimental/custom-question-type
September 16, 2020 17:37
...nt-question-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, again 👋
This is also something we need: A question type where we can show our own components (e.g. contact forms). This PR adds such component and I also added a seperate example for it where you can test it out.
It currently adds two props to the question model:
component-> Here the user needs to supply their component.validateComponent-> If set to true "vue-flow-form" will call the isValid() method on the given component to check if its valid before it continues.If you have any questions or feedback, just let me know 😀