-
Notifications
You must be signed in to change notification settings - Fork 136
load_document: Lower priority of HTML inputs #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes a bug with activitypub related documents: The schema "https://www.w3.org/ns/activitystreams" renders the spec if "application/json" has a lower prioritisation than "text/html".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We define headers['Accept'] here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and we modify that value here.
- Would it be possible to specify the final value right away?
- Probably a comment explaining what the magic
0.5means would also be helpful to future readers.
This looks fine generally, but lets get some tests written for it. @anatoly-scherbakov would you be up for doing that to test out the "local tests" you were sad we didn't have here?
This fixes a bug with activitypub related documents: The schema "https://www.w3.org/ns/activitystreams" renders the spec if "application/json" has a lower prioritisation than "text/html".