-
Couldn't load subscription status.
- Fork 139
Add support for Spring boot 2.1.0 and Lovelace SR2 #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I cant run format on windows its add windows line endings
Codecov Report
@@ Coverage Diff @@ ## master #213 +/- ## =========================================== + Coverage 65.21% 65.4% +0.19% - Complexity 598 600 +2 =========================================== Files 77 77 Lines 2038 2038 Branches 374 374 =========================================== + Hits 1329 1333 +4 + Misses 554 550 -4 Partials 155 155
Continue to review full report at Codecov.
|
Loss of code coverage is due to Spring making more interfaces final making Mockito useless.
Loss of code coverage issues resolved
... regression on live site.
@derjust any intention of throwing up this snapshot Spring 2.1 is GA and I would love to move away from a local repo
Appreciate it - looks good!
Right now thinking about the various versions that are out there to be supported - honestly dislike that they introduced a new method signature again.
Merging with #17
Agree plus all the new final classes, was not hard to get it working, but I shouldn't have had to make any changes at all
ryonday
commented
Nov 13, 2018
I am fine with whatever, I just needed it for my project so I did it, looks like we came to same solution although I think I handled the code coverage a bit different, do a diff and you can see. I think mine is more the "Mockito" way, I could be wrong though. Been a while since I used Mockito.
Also I have some fixed to get it to build on windows environments properly in the POM as well, I know that's rare but it's still useful :)
@ryonday let me know if you want to merge into my branch and PR or go the other way around and we'll get the permission sorted and what not.
Also @derjust if you need some help administering the project let me know, I've contributed to a few spring data projects in the past (solr, jpa, now dynamo)
@devinsba
devinsba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you don't mind @derjust but my team needs this code too so I figured another review might help you finalize this
...a/org/socialsignin/spring/data/dynamodb/config/DynamoDBAuditingBeanDefinitionParserTest.java
Outdated
Show resolved
Hide resolved
...va/org/socialsignin/spring/data/dynamodb/repository/query/PartTreeDynamoDBQueryUnitTest.java
Outdated
Show resolved
Hide resolved
Incorporated @devinsba feedback
@derjust just tested this all against SR2 to be sure and we are good.
A thousand thanks to all!
@boostchicken @ryonday @devinsba all appreciate your work!
I merged all of those into branch derjust:Issue_218 to keep all your commits intact & provide credits.
Any help is always highly appreciated and I hope to have more free time soon again.
Still interessted in the changes for a Windows build :-)
No description provided.