-
Couldn't load subscription status.
- Fork 107
added more german nobility titles #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kaspersorensen
kaspersorensen
Dec 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion from my side would be to normalize the apostrophes and dashes prior to matching against these lists. There are too many variations to capture them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely agreed; I did not take the time to take a look if this happens already somewhere in the code... Obviously there's a bunch of misused characters that might function as apostrophes, even if we only take into account latin script, e.g. '’‘' and the backtick that ` creates the <code/>. Search the unicode.org charts for all other apostrophes for other writing systems
@fdesoye
fdesoye
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would benefit from this MR as I will have to deal with German names soon. Would it be reasonable to move the debate about apostrophes to a dedicated issue so that the rest of the contribution could be released?
@kaspersorensen
kaspersorensen
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me. The PR is quite old. So I guess it needs to have conflicts resolved etc.
Inspired by the question on "frau" (in #99), I dropped in a couple more titles from German language (specifically from nobility titles of 19th century Austrian government members).