Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update collections import in data_structures.py #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msf235 wants to merge 1 commit into ddbourgin:master
base: master
Choose a base branch
Loading
from msf235:master

Conversation

@msf235
Copy link

@msf235 msf235 commented Aug 5, 2023
edited
Loading

Updated Hashable import from collections to support most recent python versions.

Most recent versions of python no longer allow "from collections import Hashable" but rather require "from collections.abc import Hashable". I've included a try-except block to take this into account.

All Submissions

  • Is the code you are submitting your own work?
  • Have you followed the contributing guidelines?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Model Submissions

  • Is the code you are submitting your own work?
  • Did you properly attribute the authors of any code you referenced?
  • Did you write unit tests for your new model?
  • Does your submission pass the unit tests?
  • Did you write documentation for your new model?
  • Have you formatted your code using the black deaults?

Changes to Existing Models

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

justinnk, CptCaptain, and althonos reacted with thumbs up emoji
Updated Hashable import from collections to support most recent python versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /