-
Couldn't load subscription status.
- Fork 3.8k
Create gaussian_discriminant_analysis.py #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that you did not use pandas package in your code. So I think you could remove this line.
Could you please create unit test for this?
Maybe you can refer sklearn-test for details.
Hi @Christakou - thanks for the submission! A few general comments:
- I notice your code relies on the pandas library. In order to be consistent with the rest of the codebase, you should modify the model to expect numpy arrays instead - no pandas allowed :)
- In order to demonstrate your code is sound, please include unit tests against an existing implementation of the model. sklearn's DiscriminantAnalysis module looks like it might be relevant here.
- Please include brief documentation in the NumPy style for the public methods in your model.
- Style: as much as possible, try to follow pep8 style conventions (e.g., camel_case for method, function, and variable names) to ensure readability. You can autoformat your code with the online Black formatter
You can see the general contribution guidelines here. Let me know if you have questions !
A framework for building general discriminant analysis models, currently implemented quadratic discriminant analysis, will later add support for linear discriminant analysis too.