Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: return False for empty string in is_email() #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RequiemBit wants to merge 1 commit into daveoncode:master
base: master
Choose a base branch
Loading
from RequiemBit:master

Conversation

@RequiemBit
Copy link

@RequiemBit RequiemBit commented Jul 13, 2025

  • Closes Bump cryptography from 2.8 to 3.2 #18
  • Empty string should not be considered a valid email.
  • Added explicit if input_string == "": return False guard in is_email().
  • Added unit test to prevent regression.
  • All existing tests still pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /