-
Couldn't load subscription status.
- Fork 8
Remove README.md as packaged data in the wheel #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheLonelyGhost
wants to merge
1
commit into
daveoncode:master
from
TheLonelyGhost:feature/readme-is-not-necessary-wheel-data
Open
Remove README.md as packaged data in the wheel #16
TheLonelyGhost
wants to merge
1
commit into
daveoncode:master
from
TheLonelyGhost:feature/readme-is-not-necessary-wheel-data
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md is not needed here except for reading to provide the `long_description` attribute in `setup.py`, which is then used only when uploading to pypi. It seems we can safely remove it from the manifest while retaining it in git. Normally the `data` published here is for non-python files necessary for the program to function (e.g., i18n translations).
Codecov Report
Merging #16 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #16 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 48 48 Lines 2621 2621 ========================================= Hits 2621 2621
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 78929d8...c31dcf0. Read the comment docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md is not needed here except for reading to provide the
long_descriptionattribute insetup.py, which is then used onlywhen uploading to pypi. It seems we can safely remove it from the
manifest while retaining it in git.
Normally the
datapublished here is for non-python files necessaryfor the program to function (e.g., i18n translations).