fix(stdio): Correct error message for Line Terminator #61735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

indraneel12 wants to merge 1 commit into dart-lang:main from indraneel12:patch-1

Closed

fix(stdio): Correct error message for Line Terminator #61735

indraneel12 wants to merge 1 commit into dart-lang:main from indraneel12:patch-1

+1 −1

Conversation

@indraneel12

Copy link

Contributor

@indraneel12 indraneel12 commented Oct 16, 2025 •

edited

Loading

Context: https://api.flutter.dev/flutter/dart-io/Platform/lineTerminator.html

With reference to the documentation and logic of lineTerminator setter, the current ArgumentError message is misleading:

r'invalid line terminator, must be one of "\r" or "\r\n"'

This fix contains just one change: the solo "\r" is corrected to "\n".

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.

Note that this repository uses Gerrit for code reviews. Your pull request will be automatically converted into a Gerrit CL and a link to the CL written into this PR. The review will happen on Gerrit but you can also push additional commits to this PR to update the code review.

@indraneel12


 fix(stdio): Correct error message for Line Terminator

79f4d00

Reference: https://api.flutter.dev/flutter/dart-io/Platform/lineTerminator.html

@copybara-service

Copy link

copybara-service bot commented Oct 16, 2025

Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at:

https://dart-review.googlesource.com/c/sdk/+/455460

Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly.

Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR).