-
Notifications
You must be signed in to change notification settings - Fork 94
[Workflow] Renamed the workflow methods #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...s used in the .NET SDK (absent the `Async` verbiage as that's not typical of JavaScript convention. Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Note to update workflow docs per this note.
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
Signed-off-by: Whit Waldo <whit.waldo@innovian.net>
...kflow-startworkflow
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.84%. Comparing base (d1bf38a) to head (5785a33).
Additional details and impacted files
@@ Coverage Diff @@ ## main #680 +/- ## ============================================ - Coverage 100.00% 54.84% -45.16% ============================================ Files 1 14 +13 Lines 6 330 +324 Branches 1 66 +65 ============================================ + Hits 6 181 +175 - Misses 0 131 +131 - Partials 0 18 +18
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed the workflow methods so they're equivalent to the method names used in the .NET SDK (absent the
Asyncverbiage as that's not typical of JavaScript convention.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #674
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: