Search code, repositories, users, issues, pull requests...

Copy link

Contributor

@XavierGeerinck XavierGeerinck commented Jul 18, 2022

Signed-off-by: Xavier Geerinck xavier.geerinck@gmail.com

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #322

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation


 Ensure sidecar starts correctly

487faa7

Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>

@XavierGeerinck XavierGeerinck requested review from a team as code owners

July 18, 2022 08:00

Continue to review full report at Codecov.


 Linting fixes

c8649b7

Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>

@codecov

Copy link

codecov bot commented Jul 18, 2022 •

edited

Loading

Codecov Report

Merging #324 (c166217) into master (5bc8eee) will increase coverage by 3.37%.
The diff coverage is 51.21%.

@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 31.34% 34.72% +3.37% 
==========================================
 Files 81 73 -8 
 Lines 5899 6126 +227 
 Branches 200 202 +2 
==========================================
+ Hits 1849 2127 +278 
+ Misses 4010 3980 -30 
+ Partials 40 19 -21

Impacted Files	Coverage Δ
src/implementation/Client/HTTPClient/sidecar.ts	`14.28% <0.00%> (-52.39%)`	⬇️
src/implementation/Server/DaprServer.ts	`60.00% <ø> (+1.17%)`	⬆️
src/implementation/Client/HTTPClient/HTTPClient.ts	`9.30% <25.00%> (-40.70%)`	⬇️
src/implementation/Client/DaprClient.ts	`58.06% <50.00%> (-12.91%)`	⬇️
src/implementation/Client/GRPCClient/sidecar.ts	`47.05% <62.50%> (+24.83%)`	⬆️
src/implementation/Client/GRPCClient/GRPCClient.ts	`67.39% <100.00%> (+53.10%)`	⬆️
src/actors/client/ActorProxyBuilder.ts	`11.76% <0.00%> (-88.24%)`	⬇️
src/implementation/Server/HTTPServer/actor.ts	`9.52% <0.00%> (-83.34%)`	⬇️
src/implementation/Server/HTTPServer/HTTPServer.ts	`16.21% <0.00%> (-67.57%)`	⬇️
src/actors/ActorId.ts	`33.33% <0.00%> (-66.67%)`	⬇️
... and 65 more

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc8eee...c166217. Read the comment docs.

shubham1172 reviewed

src/implementation/Client/HTTPClient/sidecar.ts Outdated Show resolved Hide resolved

shubham1172 reviewed

src/implementation/Client/HTTPClient/HTTPClient.ts Outdated Show resolved Hide resolved

shubham1172 reviewed

src/implementation/Client/HTTPClient/HTTPClient.ts Show resolved Hide resolved

shubham1172 reviewed

src/implementation/Client/GRPCClient/sidecar.ts Show resolved Hide resolved

shubham1172 reviewed

src/implementation/Client/GRPCClient/sidecar.ts Show resolved Hide resolved

shubham1172 reviewed

src/implementation/Client/GRPCClient/GRPCClient.ts Show resolved Hide resolved

shubham1172 reviewed

src/implementation/Client/DaprClient.ts Show resolved Hide resolved

shubham1172 suggested changes

Copy link

Member

@shubham1172 shubham1172 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.

XavierGeerinck added 3 commits

July 18, 2022 13:11


 Resolve some comments

772bc69

Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>


 Give more time for timeout

c61ed6a

Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>


 Changes

c166217

Signed-off-by: Xavier Geerinck <xavier.geerinck@gmail.com>

@XavierGeerinck XavierGeerinck merged commit 13afefe into dapr:master