-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(schema-compiler): Fix inherited drill members for views #9966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+201
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
@KSDaemon
KSDaemon
force-pushed
the
fix/inherit-drill-members
branch
from
September 22, 2025 07:23
16db64a to
ca9d3b7
Compare
@KSDaemon
KSDaemon
force-pushed
the
fix/inherit-drill-members
branch
from
October 15, 2025 18:21
4e37f9d to
25fd1d2
Compare
@github-actions
github-actions
bot
added
the
javascript
Pull requests that update Javascript code
label
Oct 15, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #9966 +/- ## ========================================== - Coverage 48.82% 48.79% -0.04% ========================================== Files 196 196 Lines 15824 15840 +16 Branches 3101 3106 +5 ========================================== + Hits 7726 7729 +3 - Misses 7706 7716 +10 - Partials 392 395 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...rror reporting # Conflicts: # packages/cubejs-schema-compiler/src/compiler/ErrorReporter.ts
@KSDaemon
KSDaemon
force-pushed
the
fix/inherit-drill-members
branch
from
October 24, 2025 11:13
25fd1d2 to
e5657b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR supersedes the original one by @paco-valdez.
Updated with a simpler one-time drillMembers evaluation.
Fixes #6778.
Closes #9959.
Check List