-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(schema-compiler): prevent member name collection from impacting joins #9942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm not quite sure why the tests are failing, they seem unrelated to the change? 🤔
@Spark-NF, thanks for trying to fix this. But well... unit tests are failing. You can try to run it locally within the schema-compiler package and examine the output with/without your changes. I'm pretty sure they are related. For example some sort of internal caches.
@KSDaemon indeed, seems like I was compiling the wrong compiler in the test I added. I guess I got confused by the CI output, downloading the CI logs and re-running the tests locally made it clear.
Check List
Issue Reference this PR resolves
#9941