Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(schema-compiler): Support joins for proxied time dimensions in pre-aggregations #10020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KSDaemon wants to merge 2 commits into master
base: master
Choose a base branch
Loading
from feat/proxy-td-in-pre-aggs

Conversation

@KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Oct 1, 2025 •
edited
Loading

This PR fixes errors for cases when pre-aggregation time dimension references member from other cubes.

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon marked this pull request as ready for review October 1, 2025 12:42
@KSDaemon KSDaemon requested a review from a team as a code owner October 1, 2025 12:42
@KSDaemon KSDaemon force-pushed the feat/proxy-td-in-pre-aggs branch from 1648ae1 to d84792b Compare October 15, 2025 18:22
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 15, 2025
Copy link

codecov bot commented Oct 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.81%. Comparing base (9a51a5a) to head (221501c).

Files with missing lines Patch % Lines
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@ Coverage Diff @@
## master #10020 +/- ##
==========================================
- Coverage 48.82% 48.81% -0.01% 
==========================================
 Files 196 196 
 Lines 15824 15827 +3 
 Branches 3101 3101 
==========================================
 Hits 7726 7726 
- Misses 7706 7709 +3 
 Partials 392 392
Flag Coverage Δ
cube-backend 48.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the feat/proxy-td-in-pre-aggs branch from 73b3f99 to d84792b Compare October 16, 2025 16:05
@KSDaemon KSDaemon requested a review from a team as a code owner October 16, 2025 16:13
@github-actions github-actions bot added driver:postgres Issues relating to the Postgres driver data source driver labels Oct 16, 2025
@KSDaemon KSDaemon force-pushed the feat/proxy-td-in-pre-aggs branch 2 times, most recently from aa7e533 to d84792b Compare October 17, 2025 13:25
@KSDaemon KSDaemon force-pushed the feat/proxy-td-in-pre-aggs branch from d84792b to 221501c Compare October 24, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paveltiunov paveltiunov paveltiunov approved these changes

@waralexrom waralexrom waralexrom approved these changes

Assignees

No one assigned

Labels

data source driver driver:postgres Issues relating to the Postgres driver javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /