-
Notifications
You must be signed in to change notification settings - Fork 109
feat: remove params.json file #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deleted the `params.json` file, which contained outdated and unnecessary content related to GitHub Pages. This cleanup helps reduce clutter and improve repository organization. (This commit message was AI-generated.) Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
The repo is still using Github’s pages though. The domain is linked to it.
Are you sure this file is needed and used? (Not to question it as you seem to know more, but to confirm and to learn more.)
I couldn’t spot any reference to it and have never seen this needed in other uses of GitHub Pages so far.
I honestly don’t remember and don’t know, but I’d rather not spend time on fixing a potential breakage.
The file do specify the following:
"note":"Don’t delete this file! It’s used internally to help with page regeneration."
So as long as we’re using Github Pages, I’d get ready to deal with potential issues, or leave it as it is. You have my preference, but feel free to move forward if you have time to monitor and fix whatever might happen.
Missed that note at the end... but this is still strange, and I’d like to investigate this. (In short, I’ve worked with GitHub Pages a few times and that never required a params.json file, least of all one that seems to make the site that brittle.)
Allow me to test this when I have some time to review what could have necessitated this, as well as to monitor.
Deleted the
params.jsonfile, which contained outdated and unnecessary content related to GitHub Pages. This cleanup helps reduce clutter and improve repository organization.(This commit message was AI-generated.)