Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DONT-MERGE-YET] Remove unnecessary dependencies in CMake. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zapolnov wants to merge 1 commit into cppfw:main from zapolnov:nz_cmake_cleanup

Conversation

@zapolnov
Copy link
Contributor

@zapolnov zapolnov commented Jun 4, 2025

No description provided.

Copy link

codecov bot commented Jun 4, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (b2c91f3) to head (5e5146e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@
## main #8 +/- ##
=======================================
 Coverage 68.89% 68.89% 
=======================================
 Files 11 11 
 Lines 704 704 
 Branches 190 190 
=======================================
 Hits 485 485 
 Misses 192 192 
 Partials 27 27 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

igagis commented Jun 4, 2025

As you can see, the vcpkg ci job fails without these dependencies:

CMake Error at /__w/cssom/cssom/build/vcpkg/test/vcpkg_installed/x64-linux/share/papki/papki-config.cmake:60 (set_target_properties):
 The link interface of target "papki::papki" contains:
 ZLIB::ZLIB
 but the target was not found. Possible reasons include:
 * There is a typo in the target name.
 * A find_package call is missing for an IMPORTED target.
 * An ALIAS target is missing.

I agree that it is not beautiful that we need to list all the transient dependencies, but vcpkg fro some reason does not work otherwise, I don't know how to fix it for now, I decided to leave it as is for now and don't spend much time figuring out how to improve it (if at all possible). Maybe sometime later, or maybe you know what is going on here...

@igagis igagis self-assigned this Jun 5, 2025
Copy link
Member

igagis commented Jun 8, 2025

fixed on main branch

@igagis igagis closed this Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /