Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed header location for catch.hpp #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glynos merged 1 commit into cpp-netlib:master from BioDataAnalysis:bda_fix_catch2_includes
May 7, 2020

Conversation

@emmenlau
Copy link

@emmenlau emmenlau commented May 7, 2020

The default install location for Catch2 is TARGETDIR/include/catch2/catch.hpp. Some tests already use this location, i.e. #include <catch2/catch.hpp> but the majority includes just <catch.hpp>.

This PR changes that. It therefore makes the includes more consistent. Tested with Catch2 v2.12.1 (latest as of today).

Fixes #89

Copy link
Member

glynos commented May 7, 2020

I really appreciate the PR! Thanks for contributing!

emmenlau reacted with thumbs up emoji

@glynos glynos merged commit a4987b3 into cpp-netlib:master May 7, 2020
@emmenlau emmenlau deleted the bda_fix_catch2_includes branch May 7, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

include catch.hpp from catch2/catch.hpp

2 participants

AltStyle によって変換されたページ (->オリジナル) /