-
Couldn't load subscription status.
- Fork 24
Clean-up README (#80) #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should be titled "clean-up README" 😄
Was the icon_large.xcf file (my GIMP project) moved to the .github repo?
Was the icon_large.xcf file (my GIMP project) moved to the .github repo?
No, what is icon_large.xcf used for? You or I move to the .github repo if needed.
En, yellow should look good in both dark and default themes, the pre-commit icon is also yellow, but our yellow icon is not sharp enough that's why I want to remove it, see https://github.com/cpp-linter/cpp-linter-action/blob/894a54988abed9f2c7a37f5b54694e819de7f462/docs/images/icon_large.png
If the new yellow icon could display well(sharp and lossless) as the current icon, we can change it to yellow. https://github.com/cpp-linter/cpp-linter-action/blob/894a54988abed9f2c7a37f5b54694e819de7f462/docs/images/icon.png
oh,
- I added a slight bevel (with shadow) to the circle so the checkmark would pop out.
- I also added a shadow to the check mark to make it seem 3D layered.
- There is some slight pixelation around the edges because I scaled it up a bit to reduce the empty space around it. Then I tried to hide that with some bevel shadows.
If you're looking for flat, that's easy.
image
This yellow circle icon looks great 👍 I would also like to see the flat
I still don't like the empty space around it, but when I scale it up, it gets pixelated.
image
What did you use to create the logo?
I found the logo from google or Canva, I forgot it 😟
Resolve #80