Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update thread-comments condition in self-test.yml #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 2 commits into main from shenxianpeng-patch-1
Sep 3, 2025

Conversation

@shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Sep 2, 2025

Right now merge PR will be added thread-comments, see b20a30f

I would like to disable it for merged commits.

Right now merge PR will be added thread-comments, see b20a30f
I would like to disable it for merged commits.
@shenxianpeng shenxianpeng added the developer Changes which impact developers label Sep 2, 2025
@shenxianpeng shenxianpeng requested a review from a team as a code owner September 2, 2025 19:48
@shenxianpeng shenxianpeng requested review from 2bndy5 and removed request for a team September 2, 2025 19:48
Copy link
Contributor

github-actions bot commented Sep 2, 2025
edited
Loading

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v16.0.6) reports: 2 file(s) not formatted
  • docs/examples/demo/demo.hpp
  • docs/examples/demo/demo.cpp
clang-tidy (v16.0.6) reports: 7 concern(s)

Have any feedback or feature suggestions? Share it here.

shenxianpeng reacted with hooray emoji

Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also update it to only post comments (and file-annotations) using clang v16

shenxianpeng reacted with thumbs up emoji
@shenxianpeng shenxianpeng merged commit e94da0a into main Sep 3, 2025
84 checks passed
@shenxianpeng shenxianpeng deleted the shenxianpeng-patch-1 branch September 3, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2bndy5 2bndy5 2bndy5 approved these changes

Assignees

No one assigned

Labels

developer Changes which impact developers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /