-
Notifications
You must be signed in to change notification settings - Fork 24
Update thread-comments condition in self-test.yml #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Right now merge PR will be added thread-comments, see b20a30f I would like to disable it for merged commits.
Cpp-Linter Report ⚠️
Some files did not pass the configured checks!
clang-format (v16.0.6) reports: 2 file(s) not formatted
- docs/examples/demo/demo.hpp
- docs/examples/demo/demo.cpp
clang-tidy (v16.0.6) reports: 7 concern(s)
-
docs/examples/demo/demo.hpp:6:11: warning: [modernize-use-default-member-init]
use default member initializer for 'useless'
char* useless; ^ {"0円"}
-
docs/examples/demo/demo.hpp:7:9: warning: [modernize-use-default-member-init]
use default member initializer for 'numb'
int numb; ^ {0}
-
docs/examples/demo/demo.hpp:11:11: warning: [modernize-use-trailing-return-type]
use a trailing return type for this function
void *not_useful(char *str){useless = str;} ~~~~~~^ auto -> void *
-
docs/examples/demo/demo.cpp:3:10: warning: [modernize-deprecated-headers]
inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead
#include <stdio.h> ^~~~~~~~~ <cstdio>
-
docs/examples/demo/demo.cpp:8:5: warning: [modernize-use-trailing-return-type]
use a trailing return type for this function
int main(){ ~~~ ^ auto -> int
-
docs/examples/demo/demo.cpp:10:13: warning: [readability-braces-around-statements]
statement should be inside braces
for (;;) break; ^ {
-
docs/examples/demo/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]
do not call c-style vararg functions
printf("Hello world!\n"); ^
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could also update it to only post comments (and file-annotations) using clang v16
Right now merge PR will be added thread-comments, see b20a30f
I would like to disable it for merged commits.