Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Check all files #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 65 commits into cpp-linter:master-py from 2bndy5:check-all-files
Oct 11, 2021
Merged

Check all files #26

shenxianpeng merged 65 commits into cpp-linter:master-py from 2bndy5:check-all-files
Oct 11, 2021

Conversation

@2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Oct 10, 2021

resolves #25

This adds some new inputs and renames 1:

  1. diff-only renamed to lines-changed-only
  2. new files-changed-only to allow crawling user's entire repo for source files to check
  3. new ignore to better filter what directories to crawl. This can also be applied when files-changed-only is enabled
  4. thread-comments to optionally enable/disable the use of thread comments. Annotations (via Log commands) will always be active despite this option.

The action's log has also been condensed into collapsible groups, but I'll let those changes "speak" for themselves.

This also closes #11 with the use of log commands. We can re-open #11 when re-attempting to make suggestions in PRs... I should note that if the lines in question are not present in the event's "Files Changed" tab, then the annotations can only be found in the workflow's summary. Creating annotations does not instigate a github account notification (usually via email), so using this action's checks-failed output would be preferable in case thread-comments is disabled.

Lastly, I updated the README (about the new input options) & added a picture of demo annotations.

2bndy5 added 30 commits October 6, 2021 02:51
@2bndy5 2bndy5 marked this pull request as ready for review October 10, 2021 15:25
@2bndy5 2bndy5 added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 10, 2021
Copy link
Collaborator Author

@2bndy5 2bndy5 left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log is saying

 INFO:CPP Linter:comments_url: https://api.github.com/repos/shenxianpeng/cpp-linter-action/issues/26/comments

but its getting a bad response

 INFO:CPP Linter:Got 403 from POSTing comment
 ERROR:CPP Linter:response returned message: {"message":"Resource not accessible by integration","documentation_url":"https://docs.github.com/rest/reference/issues#create-an-issue-comment"}

I am investigating this, but it seems like it should be correct. I didn't change how PR comments are posted in this branch.

Copy link
Collaborator Author

2bndy5 commented Oct 10, 2021
edited
Loading

REST API docs says (about posting issue comments - which is the same API used to post PR comments):
image

Looks like there's a conflict of security. I think the GITHUB_TOKEN that is used on my branch cannot make comments on this upstream repo.

Copy link
Collaborator

@shenxianpeng shenxianpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2bndy5 reacted with thumbs up emoji
@shenxianpeng shenxianpeng merged commit 8da68c8 into cpp-linter:master-py Oct 11, 2021
shenxianpeng added a commit that referenced this pull request Oct 11, 2021
* Parse better with python (#22)
* upload new demo image
* Revert "upload new demo image"
This reverts commit 1aff6c7.
* update readme & upload new demo pic
* avoids duplicated checks on commits to open PR
* fix workflow from the last commit
* Revert "fix workflow from the last commit"
This reverts commit 778e10d.
* create python scripts
* output event payload & pip3 ver
* echo pip3 list
* switch action to this branch
* echo pip3 list
* install pip and list modules
* typo
* pip3 install requests
* switching to only python
* should've read the docker docs
* switching back to ENTRYPOINT
* typo
* don't upgrade if files exist outside /use dir
* use python as an entrypoint
* add project.toml
* bad syntax
* try again
* hard_code version in setup.py
* try pip install
* only upgrade pip
* test on source files
* headers are dicts
* test on source files
* fix posting comment using requsts
* fix passing verbosity to CLI args
* action uses current branch for now
* parsing everything; no diff action yet
* show all debug in logs
* use bot's id not mine
* double trigger action
* auto-verbose logging on repeated runs
* show me then run number
* support sync events in PRs
* switch to mkdocs
* fix bad indent in yml
* install pkg before documenting
* typo
* compatible w/ windows; add diff-only input option
* diff comments working on PR from clang-tidy advice
* rolling back diff comments; update docs
* use bot id
* disable diff-only in demo
* Update setup.py
* try mkdocs gh-deploy
* use a gh action to publish docs
* oops. ignoe release only condition for now
* change doc's favicon
* [no ci] publish docs only on release event
* rename docs CI workflow
* prototype badge
* [no ci] augment doc build instructions
* update readme & demo picture
* [no ci] pub docs on release
* update docs
* disable mkdocs CI (switching to rtfd CI)
* fix some review suggestions
* update badge in readme
* Use lazy % formatting in logging functions
* fix more code-inspector notices
* slight refactor and switch to pylint
* fix pylint workflow
* run pylint on PR synch events too
* Tell code-inspector to ignore python srcs
* Tell code inspector to ignore mkdocs.yml
* ran black
* self review changes
* Update .github/workflows/run-pylint.yml
* add gitpod badge to root README.md
* try to fix verify_files_are_present()
* remove <br> to auto adjust and easy copying
* fixed typo
* solution to #24
* using check=True causes #24
* log non-zero exit codes as warnings
* warn (in log) about no git checkout
* Update action name
Update the name to make it easier to search in the marketplace when users search with clang-format or clang-tidy.
* Revert "Update action name"
This reverts commit 4a41a5e.
* Upadate README.md
* Check all files (#26)
* initial attempt (#25)
* change test action to my branch
* adjust workflow triggers
* try log grouping with logger.critical()
* change logger's format
* don't upgrade pip; test some new features
* test fake submodule; show me args.ignore on boot
* considering alternate fmt for ignore option
* remove fake submodule (it worked);
* action inputs can't take a sequence; delimit by \n
* specifying `--ignore` better
* fix exit early when no files found
* list_source_files() is malfunctioning???
* Revert "list_source_files() is malfunctioning???"
This reverts commit 59522e0.
* is ignore option causing malfunction?
* show me what paths are being skipped
* show me which paths are crawled
* show me which files are considered as src files
* show me comparison of ignored paths
* change done debug statements
* fix debugging statement in is_file_ignored()
* skip comparing empty strings in ignored paths
* maybe a bug about ignoring root dir
* try getting python latest from src
* python src build needs deps. revert to apt build
* try using tojson()
* bad yml fmt
* try a different json approach
* make yml array an explicit str
* try forcing it as a py list
* abandon json idea
* try new log_cmder and !ignore prefix
* need to separate a single str into multi args
* use pipe char as delimiters
* slightly different approach to passing ignore val
* might need to switch to 1 line of input
* how to handle spaces in a path among multiple
* no need to escape quotes
* fix debug prompts; and workflow-triggered paths
* fix cpp-linter-test action's triggered paths
* check action stil works without using new features
* try log cmds to annotate
* try abbotations again
* use a long unlikely string as default ignore
* try annotating with line and columns
* try \n with minimal parameters
* does file need changes to show annotation?
* use html <br> and line's columns
* trigger annotations
* adjust annotation's output
* try CRLF
* simply can't use mult-line annotation msg
* almost ready for PR
* use proper casing in chosen style name
* adjust last commit for GNU style as well
* remove artifact
* we don't need the `re` module anymore
* new thread-comments option; update docs & README
* avoid duplicate clang-tidy comments
* [no ci] proofread README
* Fix indent in root README for mkdocs
* Use sub-headings instead of list points in README
* reviewed errors in docs
* switch test workflow to upstream action
* Update the new example yml and remove old demo link
Co-authored-by: Brendan <2bndy5@gmail.com>
@2bndy5 2bndy5 deleted the check-all-files branch October 11, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shenxianpeng shenxianpeng shenxianpeng approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /