Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Support clang-tools version 18 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenxianpeng merged 1 commit into main from update-docs-and-action-file
Mar 7, 2024
Merged

Conversation

@shenxianpeng
Copy link
Collaborator

@shenxianpeng shenxianpeng commented Mar 7, 2024 •
edited
Loading

In addition to #203, I also made the following changes.

  • update description, add clang-tools v18 to action.yml
  • add clang-tools v18 to inputs-outputs.md
  • Follow up Update for transfer ownership #60 , change author from shenxianpeng to cpp-linter in action.yml after transfer.
 

* action.yml - change author from shenxianpeng to cpp-linter, update description, add clang 18
* add clang 18 to inputs-outputs.md
@shenxianpeng shenxianpeng added documentation Improvements or additions to documentation enhancement New feature or request labels Mar 7, 2024
@shenxianpeng shenxianpeng marked this pull request as ready for review March 7, 2024 04:35
@shenxianpeng shenxianpeng changed the title (削除) Support clang-tools version 18 and change author to cpp-linter (削除ここまで) (追記) Support clang-tools version 18 (追記ここまで) Mar 7, 2024
@shenxianpeng shenxianpeng merged commit 494ce6d into main Mar 7, 2024
@shenxianpeng shenxianpeng deleted the update-docs-and-action-file branch March 7, 2024 04:41
Copy link
Collaborator Author

image

Oh, no... the new draft release can not be published because the description is more than 125 characters.

We need to change it from

Linting C/C++ code integrating clang-tidy and clang-format to collect feedback provided in the form of file-annotations, thread-comments, workflow step-summary, and Pull Request reviews.

to a new one, like

Linting C/C++ code integrating clang-tidy and clang-format provides feedback in a variety of ways.

Any other suggestions?

Copy link
Collaborator

2bndy5 commented Mar 7, 2024

Yeah, that seems fine. It is difficult to summarize everything this action can do in 125 characters. Clearly, I'm not big on using social media 🤣

I figure if anyone clicks on our action in the marketplace, they should see the pictures and get a sense of what we are offering.
shenxianpeng reacted with laugh emoji

Copy link
Collaborator

2bndy5 commented Mar 7, 2024 •
edited
Loading

How about

Linting C/C++ code with clang-tidy or clang-format to give feedback as comments, PR reviews, and more.
shenxianpeng reacted with thumbs up emoji

Copy link
Collaborator Author

Thank you.

shenxianpeng added a commit to cpp-linter/test-cpp-linter-action that referenced this pull request Mar 7, 2024
2bndy5 pushed a commit to cpp-linter/test-cpp-linter-action that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2bndy5 2bndy5 2bndy5 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /