-
Notifications
You must be signed in to change notification settings - Fork 211
fix: Patch commands fail trying to re-apply the same patch twice #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Patch commands fail trying to re-apply the same patch twice #664
Conversation
BohdanBuinich
commented
Jun 11, 2025
@TheLartians, Could you please review this change and let me know if you agree with it?
aaeberharter
commented
Jun 12, 2025
I pulled CPM.cmake from the PR and it works for me.
cmake version 3.31.6-msvc6 (bundled with Visual Studio 2022)
Thank you
aaeberharter
commented
Jun 13, 2025
PATCH_OPTIONS are mentioned in README.md but are not used in CPM.cmake. After this PR is merged we should discuss how to add meaningful patch options.
5060d97 to
3c3ebf1
Compare
edunad
commented
Jun 19, 2025
Any updates? I'm using the temp fix of SET after the first time cmake runs, but that doesn't work 100% of the time, would be awesome to get this merged soon 💖
BohdanBuinich
commented
Aug 11, 2025
@TheLartians, what do you think about this fix? Or do you think it’s too messy and have a better idea for handling it?
Fixes #618