-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
feat: add edit this post link #2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This seems like an interesting feature, but blog and documentation websites have different purposes. Most people wouldn't invite others to modify their posts, so the priority for implementing this feature isn't very urgent.
The current PR design, placing new links at the bottom of posts, looks a bit cluttered. I plan to revisit this feature once I have time to think of a cleaner UI layout.
Thanks! I mainly wanted to experiment with implementing this feature since there was a request for it. I completely agree with your points, the feature definitely needs some refinement, as you mentioned. I also understand that people might use the theme differently from what was originally intended, so it could still be useful in some cases. Anyway, I'll rely on your decision regarding how to proceed. No hard feelings 😀
Type of change
Description
Add "Edit this post" link at the bottom of the post, so it is easier for users to contibute to the blog content.
The feature is disabled by default and should be enabled and configured by editing
_data/edit-this-post.yml.Additional context
Closes #2067
Demo
image