-
-
Notifications
You must be signed in to change notification settings - Fork 980
Filter environment variables #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nicomt
nicomt
changed the title
(削除) Filter environmet variables to prevent unintended leakage of environment variables. (削除ここまで)
(追記) Filter environment variables (追記ここまで)
Jun 6, 2024
@nicomt Thank you for this PR. I think that the best solution is to follow the official Vite documentation and remove process.env from vite.config.mjs - https://vitejs.dev/guide/env-and-mode
mrholek
mrholek
approved these changes
Jun 14, 2024
👌I agree. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Filter environment variables to prevent unintended leakage of environment variables.