Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Migrate from setuptools to poetry #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rayokota wants to merge 1 commit into master
base: master
Choose a base branch
Loading
from poetry
Draft

Migrate from setuptools to poetry #1900

rayokota wants to merge 1 commit into master from poetry

Conversation

@rayokota
Copy link
Member

@rayokota rayokota commented Jan 9, 2025

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required

References

JIRA:

Test & Review

Open questions / Follow-ups

Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

[tool.poetry]
packages = [{include = "confluent_kafka", from = "src"}]

[tool.poetry.dependencies]
Copy link
Member

@pranavrth pranavrth Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving optional dependencies to required ones. Most of the users of this client don't use schema registry and we shouldn't install those dependencies by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pranavrth pranavrth pranavrth left review comments

@MSeal MSeal Awaiting requested review from MSeal MSeal will be requested when the pull request is marked ready for review MSeal is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /