-
Notifications
You must be signed in to change notification settings - Fork 23
Revert moving ActivateDispatchers to worker Execute #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ trevorr
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.
Thanks for the PR @trevorr , but this will make the oauthbearer tests fail (as the connection requires the dispatchers to be active in that case).
I was working on a PR for this already. It's still not finished, but I cleaned it up a little and raised it as #190 , as I realized you might want to verify if that works for you. I tested with a similar assertion added about the threads as present in the original issue, and with further tests I did.
It's great to hear there's a PR in progress. I just wanted to share what we're using for now as a straw man proposal. I'll go ahead and close this since you have a fix on the way.
Fixes #161 by moving
ActivateDispatchersback toHandleOKCallback. We're using this fix on a fork, and have verified that it fixes the hang.