Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Revert moving ActivateDispatchers to worker Execute #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

@trevorr
Copy link

@trevorr trevorr commented Nov 26, 2024

Fixes #161 by moving ActivateDispatchers back to HandleOKCallback. We're using this fix on a fork, and have verified that it fixes the hang.

@trevorr trevorr requested review from a team as code owners November 26, 2024 20:52
Copy link

confluent-cla-assistant bot commented Nov 26, 2024
edited
Loading

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ trevorr
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link
Contributor

milindl commented Nov 27, 2024
edited
Loading

Thanks for the PR @trevorr , but this will make the oauthbearer tests fail (as the connection requires the dispatchers to be active in that case).

I was working on a PR for this already. It's still not finished, but I cleaned it up a little and raised it as #190 , as I realized you might want to verify if that works for you. I tested with a similar assertion added about the threads as present in the original issue, and with further tests I did.

Copy link
Author

trevorr commented Nov 27, 2024

It's great to hear there's a PR in progress. I just wanted to share what we're using for now as a straw man proposal. I'll go ahead and close this since you have a fix on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Producer/consumer connect corrupts libuv async queue

2 participants

AltStyle によって変換されたページ (->オリジナル) /