-
Couldn't load subscription status.
- Fork 23
Add commitCb method #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
to avoid blocking while committing and return a Promise without having to call consumer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK beside a minor comment
lib/kafkajs/_consumer.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep it async to meet the kafkajs API, and it'll work since we're returning a promise anyway
to avoid blocking while committing
and return a Promise without having
to call consume()