Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix/bottom nav visibility mediadetails #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kota-Jagadeesh wants to merge 2 commits into commons-app:main
base: main
Choose a base branch
Loading
from Kota-Jagadeesh:fix/bottom-nav-visibility-mediadetails

Conversation

@Kota-Jagadeesh
Copy link
Collaborator

@Kota-Jagadeesh Kota-Jagadeesh commented Oct 16, 2025

Fix Bottom Navigation Bar Disappearing in MediaDetailPagerFragment

Changes

  • MediaDetailPagerFragment.kt: Removed the hideTabs() call in onCreateView to prevent hiding the bottom navigation bar when displaying media details, ensuring it remains visible as per the requirement.
  • MainActivity.kt: Added showTabs() calls in the onBackPressed method for all navigation cases to ensure the bottom navigation bar is restored when navigating back from any fragment, providing a robust fallback.

Testing

  • Navigated from Nearby to Explore > Map tab, clicked a picture to open the bottom sheet, and then clicked "Details" to view MediaDetailPagerFragment. Verified that the bottom navigation bar remains visible.
  • Tested back navigation to ensure the navigation bar stays visible when returning to the Explore tab.
  • Tested other navigation paths (e.g., Contributions and Bookmarks to media details) to confirm consistent visibility of the navigation bar.

Fixes #6316

Copy link

✅ Generated APK variants!

Copy link
Member

This bug prevents me from testing: #6530

Are you getting the same bug?

Thanks!

Copy link
Collaborator Author

This bug prevents me from testing: #6530

Are you getting the same bug?

Thanks!

@nicolas-raoul Yep, even i am getting the same bug (#6530)
I tried this with the main branch as well, but the result is same.

nicolas-raoul reacted with eyes emoji

Copy link
Collaborator Author

@nicolas-raoul This PR fixes the issue #6316 - Can we merge this PR ?

Copy link
Member

Sorry I have very limited time this week. 😱

Copy link
Collaborator Author

Sorry I have very limited time this week. 😱

No worries! Thanks for the update - I’ll check back next week for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-raoul nicolas-raoul Awaiting requested review from nicolas-raoul

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bottom navigation bar disappears when tapping Nearby>Explore>Details

AltStyle によって変換されたページ (->オリジナル) /