-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix/bottom nav visibility mediadetails #6520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/bottom nav visibility mediadetails #6520
Conversation
✅ Generated APK variants!
This bug prevents me from testing: #6530
Are you getting the same bug?
Thanks!
@nicolas-raoul Yep, even i am getting the same bug (#6530)
I tried this with the main branch as well, but the result is same.
@nicolas-raoul This PR fixes the issue #6316 - Can we merge this PR ?
Sorry I have very limited time this week. 😱
Sorry I have very limited time this week. 😱
No worries! Thanks for the update - I’ll check back next week for your review.
Fix Bottom Navigation Bar Disappearing in MediaDetailPagerFragment
Changes
hideTabs()call inonCreateViewto prevent hiding the bottom navigation bar when displaying media details, ensuring it remains visible as per the requirement.showTabs()calls in theonBackPressedmethod for all navigation cases to ensure the bottom navigation bar is restored when navigating back from any fragment, providing a robust fallback.Testing
MediaDetailPagerFragment. Verified that the bottom navigation bar remains visible.Fixes #6316