-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix: Show captions instead of filenames in Explore > Map (Fixes #6294) #6299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
app/src/main/java/fr/free/nrw/commons/explore/map/ExploreMapController.java
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.kt
Show resolved
Hide resolved
Hi @nicolas-raoul,
All requested changes have been made. Please let me know if anything else is needed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before submitting, please review each changed line and ask yourself whether it is really needed to fix that particular issue? If not, revert it. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind including only changes that are relevant to the issue at hand? Thanks!
Hi Rajas,
Did you get a chance to check my comments? Thanks! :-)
Description (required)
Fixes #6294
What changes did you make and why?
Updated the Explore > Map view to display the caption (in the user's language) instead of the filename on green pins.
If a caption is unavailable, the app falls back to showing the filename.
Improves usability and localization, matching the behavior in Explore > Featured.
Tests performed (required)
Tested ProdDebug build variant on Medium Emulator (API 36) and Pixel 7 Emulator (API 34).
Verified:
Captions appear correctly on green pins when available.
Filenames are shown when captions are missing.
Clicking pins opens the bottom sheet without crashes.
Behavior verified even when some media items lack captions.
Screenshots (for UI changes only)
No UI layout changes.
Only the text label of the green pins was updated based on available captions.