-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update fragment_media_detail.xml #6290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Generated APK variants!
Can you mark it as draft? Thank you! :-)
I went ahead and changed it to draft. Please feel free to change it back when it's ready.
I think for now the part where you fill the new fields with actual data is missing.
Did you get a chance to continue working on this?
The changes to fragment_media_detail.xml look great, but the most important towards fixing #6265 is left. :-)
I’ve made good progress with the changes to fragment_media_detail.xml, and I’ve worked through most of the technical setup. However, I’m currently facing an issue related to the app not properly instantiating the app component, as seen in the logcat error. This is preventing the app from running as expected, and I’m trying to resolve it now.
However, I’m currently facing an issue related to the app not properly instantiating the app component, as seen in the logcat error. This is preventing the app from running as expected, and I’m trying to resolve it now.
Hi @ananas304, are you still blocked on this? If so, could you share the logcat or raise a help needed issue? Happy to take a look and see if we can help out! :)
Description (required)
Fixes #6265
What changes did you make and why?
I worked on displaying missing metadata (author, source, and uploader) on the media detail page. These fields were not previously visible when available in the media object. The XML layout was updated to include TextViews for this information, ensuring that if the data is present, it is shown correctly to users.
Tests performed (required)
Tested ProdDebug on Pixel 6 emulator with API level 30..
Screenshots (for UI changes only)
image
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.