Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add parameter to changelog generation #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dornech wants to merge 3 commits into commitizen-tools:master
base: master
Choose a base branch
Loading
from dornech:master

Conversation

@dornech
Copy link

@dornech dornech commented Sep 20, 2025
edited
Loading

... to identify incremental generation run in the jinja template.
This allows to include / exclude f. e. header lines form the current generation run to avoid multiple generation of header line(s)

Please refer to #1620

tree,
self.cz.template_loader,
self.template,
incremental=self.incremental
Copy link
Contributor

@bearomorphism bearomorphism Sep 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comma at the end of line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I tested locally and did the change directly in GitHub ...
But thanks it is being considered at least for release 4.11, I think it is a simple change with real benefit for many.

bearomorphism reacted with thumbs up emoji
Copy link
Contributor

It'd be better to add test cases related to #1620, thanks.

Lee-W reacted with thumbs up emoji

@Lee-W Lee-W added this to the 4.11.0 milestone Sep 21, 2025
fix of previous change/commit regarding same topic
Copy link

codecov bot commented Sep 21, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.25%. Comparing base (120d514) to head (2facaca).
⚠️ Report is 807 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
+ Coverage 97.33% 98.25% +0.91% 
==========================================
 Files 42 58 +16 
 Lines 2104 2694 +590 
==========================================
+ Hits 2048 2647 +599 
+ Misses 56 47 -9 
Flag Coverage Δ
unittests 98.25% <ø> (+0.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woile woile Awaiting requested review from woile woile is a code owner

@Lee-W Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

1 more reviewer

@bearomorphism bearomorphism bearomorphism left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /