-
-
Notifications
You must be signed in to change notification settings - Fork 302
test: rename the fixture config to mock_config for better code search #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: rename the fixture config to mock_config for better code search #1619
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## v4-9-2 #1619 +/- ## ========================================= Coverage ? 98.32% ========================================= Files ? 58 Lines ? 2684 Branches ? 0 ========================================= Hits ? 2639 Misses ? 45 Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not mocking a config here. We're providing a sample config instead. mock_config is inaccurate. I probably would try sample_config or something similiar
Description
There are too many things called
configin this repo (we have module, parameter key, etc).Added a prefix
mock_so we can distinguish them more easily.