-
-
Notifications
You must be signed in to change notification settings - Fork 302
feat: add check against default branch #1519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add check against default branch #1519
Conversation
93f3c0b to
9627306
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## v4-9-0-test #1519 +/- ## ============================================== Coverage ? 98.31% ============================================== Files ? 58 Lines ? 2671 Branches ? 0 ============================================== Hits ? 2626 Misses ? 45 Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8ec2c66 to
3c7623f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the naming issue, everything looks great. a wonderful feature we should have long ago
3c7623f to
5232634
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nitpick. but overall looks great!
tests/test_git.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be separate as 2 test cases instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, please review
5232634 to
264c2d0
Compare
Uh oh!
There was an error while loading. Please reload this page.
Description
Related PR: #1400
Wait for #1472 and #1457
Related issue: #1498
cz check --default-range.Some TODOs
Checklist