-
-
Notifications
You must be signed in to change notification settings - Fork 302
Upgrade ruff and add RUF022 & RUF100 #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gbaian10
gbaian10
requested review from
Lee-W,
noirbizarre and
woile
as code owners
May 31, 2025 07:52
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## refactors #1482 +/- ## ========================================== Coverage 97.82% 97.82% ========================================== Files 57 57 Lines 2619 2619 ========================================== Hits 2562 2562 Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
bearomorphism
commented
May 31, 2025
+1
Contributor
bearomorphism
commented
Jun 1, 2025
LGTM.
Member
Lee-W
commented
Jun 8, 2025
LGTM.
I think you can actually approve this PR haha.
Lee-W
Lee-W
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
resolved #1474
Ruff#1474In addition to upgrading the version, two new rules have been added:
One is RUF022, which is similar to
isort. It checks for__all__definitions that are not ordered according to an "isort-style" sort.The other is RUFF100, which is similar to
unused-ignoreofmypy. It ensures that ineffective# noqacomments are removed.Both of these can be automatically and safely fixed using
ruff check --fix.Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context