-
-
Notifications
You must be signed in to change notification settings - Fork 302
fix(tags): import Self from typing for Python 3.11+
#1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
noirbizarre
wants to merge
1
commit into
commitizen-tools:master
from
noirbizarre:fix/self-python-311plus
Closed
fix(tags): import Self from typing for Python 3.11+
#1365
noirbizarre
wants to merge
1
commit into
commitizen-tools:master
from
noirbizarre:fix/self-python-311plus
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1365 +/- ## ========================================== + Coverage 97.33% 97.69% +0.35% ========================================== Files 42 57 +15 Lines 2104 2648 +544 ========================================== + Hits 2048 2587 +539 - Misses 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4 tasks
Member
Author
noirbizarre
commented
Mar 2, 2025
Duplicate #1364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
typing-extensionsis not installed for Python 3.11+, so fix the import properly.Note
CI was not failing as
typing-extensionsis a transitive dependency of multiple test/lint dependencies but is missing as soon ascommitizenis installed alone.Checklist
poetry alllocally to ensure this change passes linter check and testExpected behavior
commitizenimport/run does not fail onSelfgit sAdditional context
I might merge this PR without review as soon as the CI pass as the latest release is broken for Python 3.11+