-
Notifications
You must be signed in to change notification settings - Fork 42
feat: optional push and commit input
#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optional push and commit input
#16
Conversation
Passing test on : https://github.com/nbrugger-tgm/commitizen-action/pull/1
Awesome work!
Had to re-commit since tests didn't work with a fork->upstream PR
Ok so the test indeed passes (tested it on my fork) but i dont know how to get running in a fork pr. I am quite a noob in git cli. Maybe can you find a way to fix the testcase to work for forke branches?
Sorry for the inconvenience
Sorry made a mistake, tested in on my repo and it worked (commit b585c72). https://github.com/nbrugger-tgm/commitizen-action/pull/3
I am sorry about the inconvenience but testing workflows especialy with forks etc is a little pain
No problem, thanks a lot actually for taking the time to do this. Can I ask you to squash into a single commit?
Thanks!
test: add test for `push` and `commit` inputs fix: test action commit failing fix: bash condtion fix: tag not found on test test: add echo for debugging to workflow fix: wrong test condition fix: missing log for new option fix: bash scripting syntax fix: commit input being inverted fix: inverted commit input fix: use the branch name instead of HEAD I have no idea why after checkout 'HEAD' sha is not the same as `origin/head_ref` but whatever fix(ci): test script not working on fork fix(ci): checking out non origin branch fix(ci): testing local state in push check Testing the push should only be done on the remote/origin
Thanks for your contribution!
Implementation of #15