Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Drop Django 3.1 related code #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amureki merged 1 commit into main from drop-legacy-from-31
Oct 17, 2022
Merged

Drop Django 3.1 related code #75

amureki merged 1 commit into main from drop-legacy-from-31
Oct 17, 2022

Conversation

@amureki
Copy link
Collaborator

@amureki amureki commented Oct 14, 2022

This PR drops code introduced in #18 to support Django 3.1:
https://docs.djangoproject.com/en/4.1/releases/3.1/#default-hashing-algorithm-settings

Since Django 3.1 support is gone, shall we get rid of this code?

@amureki amureki self-assigned this Oct 14, 2022
This PR drops code introduced in #18 to support Django 3.1:
https://docs.djangoproject.com/en/4.1/releases/3.1/#default-hashing-algorithm-settings
Since Django 3.1 support is gone, shall we get rid of this code?
Copy link

codecov bot commented Oct 14, 2022
edited
Loading

Codecov Report

Base: 99.69% // Head: 100.00% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (0658203) compared to base (746ccaa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@ Coverage Diff @@
## main #75 +/- ##
===========================================
+ Coverage 99.69% 100.00% +0.30% 
===========================================
 Files 21 20 -1 
 Lines 332 339 +7 
===========================================
+ Hits 331 339 +8 
+ Misses 1 0 -1 
Impacted Files Coverage Δ
mailauth/contrib/user/admin.py 100.00% <100.00%> (ø)
...0005_emailuser_email_hash_alter_emailuser_email.py 100.00% <100.00%> (ø)
mailauth/contrib/user/models.py 100.00% <100.00%> (ø)
mailauth/contrib/user/signals.py 100.00% <100.00%> (ø)
mailauth/signing.py 100.00% <100.00%> (ø)
mailauth/views.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@amureki amureki merged commit 57fe5b5 into main Oct 17, 2022
@amureki amureki deleted the drop-legacy-from-31 branch October 17, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codingjoe codingjoe codingjoe approved these changes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /