Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use flit-gettext to compile gettext in distributions #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codingjoe merged 1 commit into main from gettext
Nov 3, 2025
Merged

Conversation

@codingjoe
Copy link
Owner

@codingjoe codingjoe commented Nov 3, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 3, 2025 10:47
@codingjoe codingjoe self-assigned this Nov 3, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the build system from flit_core/flit_scm to flit-gettext with SCM support to enable automatic compilation of gettext translation files during the package build process. The project contains German translations in .po files that need to be compiled.

  • Replaces flit_core and flit_scm with flit-gettext[scm] in the build system configuration
  • Updates the build backend module path from flit_scm:buildapi to flit_gettext.scm
  • Adds gettext system dependency installation to CI and release workflows

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
pyproject.toml Updates build system requirements and backend to use flit-gettext for translation support
.github/workflows/release.yml Adds gettext installation step before building release artifacts
.github/workflows/ci.yml Adds gettext installation step before building distribution packages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

codecov bot commented Nov 3, 2025
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.41%. Comparing base (746ccaa) to head (1c37345).
⚠️ Report is 112 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 99.69% 99.41% -0.29% 
==========================================
 Files 21 21 
 Lines 332 343 +11 
==========================================
+ Hits 331 341 +10 
- Misses 1 2 +1 
Flag Coverage Δ
python-3.10 93.00% <ø> (?)
python-3.11 93.00% <ø> (?)
python-3.12 93.00% <ø> (?)
python-3.13 93.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codingjoe codingjoe merged commit c5f4abc into main Nov 3, 2025
20 of 21 checks passed
@codingjoe codingjoe deleted the gettext branch November 3, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /