Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Polling endpoint #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jatinkatyal13 merged 3 commits into coding-blocks:master from prabalsingh24:polling-endpoint
May 24, 2020
Merged

Conversation

@prabalsingh24
Copy link
Contributor

@prabalsingh24 prabalsingh24 commented May 22, 2020
edited
Loading

fixes #74
`

  • create a new folder src/routes/api/submissions

    • create an index.ts file which'll act as the url map
    • create an controller.ts file which'll export an object containing the handler
    • mount /api/submissions/:id endpoint to the polling controller
  • write test for the api

    • Test if the API fives 403 if the api key is not provided or incorrect
    • Test if the API gives 404 if submission id not found
    • Test if the API gives returns the serialized submission model
    • update the test here and here

`

Copy link
Contributor Author

@jatinkatyal13 Have a look at this when you're free :)

Copy link
Contributor

Nice Job 🚀

@jatinkatyal13 jatinkatyal13 merged commit 168f3a1 into coding-blocks:master May 24, 2020
Copy link

Congratualtions @prabalsingh24, your pull request is merged! 🎉

Thanks for your contributions and participating in BOSS 2020. 🙌

You can claim your bounty points here. 💰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jatinkatyal13 jatinkatyal13 jatinkatyal13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add polling endpoint

AltStyle によって変換されたページ (->オリジナル) /