I changed the config file. Changed the DB to judgeapi-tests. So make sure you create another similar DB in postgres.
I think it would be better to have a test-config.json. and modify the npm test to use that config. Your thoughts?
@jatinkatyal13

sounds good ! All the test config will be isolated from the main config. Just make sure to isolate them in the code as well.

I found some errors in the code. I've marked them as TODO in the tests. Should I go and open the issue or just solve them in this PR only.
I guess it'd be better if you have a look at them first ( I might be wrong :P)

Also out of curiosity, what do you mean by 'Referer' in api whitelist domains. here

And shouldn't it be apiKey.whitelist_domains.indexOf('Referer') !==-1

Impressive pull request 🚀

The entire purpose of having the tests is to have a code that works in the production environment. We can fix these errors in different PRs, but identifying them with the exhaustive set test is important.

Let's just Review the ToDos in the test and complete the PR

@jatinkatyal13 Have a look at the PR when you're free :)

EDIT : tldr, I fixed it :)

I need your help with test-config thing.

I am not able to change the process.env.NODE_ENV

I changed npm test to
cross-env NODE_PATH=src node_modules/.bin/mocha --timeout 12000 --exit --require ts-node/register test/unit/validators/*.ts test/e2e/*.ts && cross-env NODE_ENV=test mocha

But the enviroment is not getting changed.

When I did this
cross-env NODE_ENV=test mocha && NODE_PATH=src node_modules/.bin/mocha --timeout 12000 --exit --require ts-node/register test/unit/validators/*.ts test/e2e/*.ts

the process.env.NODE_ENV was getting changed to test but throwing No test files found error

about 1400 lines of code 😪
I hope I haven't made many mistakes 😅

We should run DB.sync once before starting the test. The test DB, in any case, will be discarded and hence we need not truncate it,

@jatinkatyal13 made the changes. Also I am doing truncateTable to make sure there no interference b/w the tests. Otherwise unexpected things might happen when something which was created in the previous tests is affecting the other tests

Generally following is the process of setting up DB

1. Setup Tables and Sequences
2. Seed mock data (Read only data common for all tests)
3. Seed data per test
4. Run test
5. Truncate per test data

Generally following is the process of setting up DB

@jatinkatyal13 I think I am also doing something similar. Waiting for a complete review :)

Setup is perfect now!

Let's remove all the TODOs and let the test fail in the case of wrong result. If the lang is incorrect we should get 400 and if the domain is not whitelisted we should get 403

Yaay. This is probably my biggest PR . :)