-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Added --whitespace=fix to git apply execution #811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...iling whitespace errors on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Can you please amend this commit with valid author information (see below) and also sign it?
git config --global user.name "Name"
git config --global user.email "email@example.com"
git config --global user.signingkey ""
git commit --amend --gpg-sign --author="Name <email@example.com>"
@crytt bump
...iling whitespace errors on Windows.
@deansheather Sorry for the delay, summer and whatnot... Commit should now be signed.
Hey OP, I'll be closing this off, are you still working on this?
Very weird failure, git wasn't found. Will restart the build.
Agreed with @sr229, lets just close this for now since V2 has different scripts/patches.
In order to prevent trailing whitespace errors on Windows.
Describe in detail the problem you had and how this PR fixes it
When running
docker build .on Windows, I got a "trailing whitespace" error.@deansheather suggested adding
--whitespace=fixto the git apply execution, and it fixed the issue.Is there an open issue you can link to?
#805