-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix Dockerfile #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
fix Dockerfile #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kylecarbs
kylecarbs
requested review from
nhooyr
and removed request for
code-asher and
kylecarbs
March 7, 2019 17:37
Could you elaborate on the error/issue you were having? I don't see what this fixes.
Ah, probably because I added the architecture to the binary name here: 994531d#diff-09fded6ea343c3bb08cac161ed7a3cbaR17
Dammit Asher. I'll push a fix for this. Thanks for pointing this out @yush1ga
See #109
@nhooyr @coderasher Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for making this awesome soft open source.
Unfortunately,
Dockerfiledoesn't work in my environment.It may depend on os arch environment.
I tried to fix it by tweaking
Dockerfile.